feat(aws-serverless)!: Use GenAI span ops for Bedrock inference - #22761
Closed
msonnb wants to merge 1 commit into
Closed
feat(aws-serverless)!: Use GenAI span ops for Bedrock inference#22761msonnb wants to merge 1 commit into
msonnb wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-5.6 Codex <codex@openai.com>
Contributor
size-limit report 📦
|
msonnb
marked this pull request as ready for review
July 28, 2026 13:58
msonnb
requested review from
andreiborza and
isaacs
and removed request for
a team
July 28, 2026 13:58
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 36653f4. Configure here.
| const spanAttributes: Attributes = { | ||
| // oxlint-disable-next-line typescript/no-deprecated | ||
| [GEN_AI_SYSTEM]: GEN_AI_SYSTEM_VALUE_AWS_BEDROCK, | ||
| [SENTRY_OP]: GEN_AI_GENERATE_CONTENT_SPAN_OP, |
There was a problem hiding this comment.
GenAI span ops missing prefix
High Severity
Bedrock spans set sentry.op to bare chat / generate_content, but every other GenAI integration in this SDK uses gen_ai.chat / gen_ai.generate_content. Core GenAI handling (extractGenAiSpansFromEvent, hasGenAiSpans, conversation ID attachment) keys off the gen_ai. prefix, so these inference spans stay misclassified and miss GenAI-specific processing.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 36653f4. Configure here.
msonnb
marked this pull request as draft
July 28, 2026 14:08
andreiborza
reviewed
Jul 28, 2026
Comment on lines
22
to
+43
| @@ -39,6 +40,7 @@ function assertBedrockSpans(transaction: TransactionEvent): void { | |||
| // InvokeModel (non-streaming, anthropic.claude request/response body) | |||
| expect(spans, 'expected a Bedrock InvokeModel span').toContainEqual( | |||
| expect.objectContaining({ | |||
| op: 'generate_content', | |||
Member
There was a problem hiding this comment.
m: Hm, we typically prefix these with gen_ai., I don't know enough about bedrock but maybe we can align here with the other ai instrumentations?
| [key: string]: any; | ||
| } | ||
|
|
||
| const GEN_AI_GENERATE_CONTENT_SPAN_OP = 'generate_content'; |
Member
There was a problem hiding this comment.
q: Do we have a task to add this to sentry conventions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
chatfor Bedrock Converse spans andgenerate_contentfor InvokeModel spans instead of genericrpc, so inference calls are classified by their GenAI operation.Part of #22446